Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to promises (and async/await) #834

Open
ORESoftware opened this issue Jun 20, 2017 · 2 comments
Open

move to promises (and async/await) #834

ORESoftware opened this issue Jun 20, 2017 · 2 comments

Comments

@ORESoftware
Copy link

ORESoftware commented Jun 20, 2017

Hey! :)

I like the API you use as is - it reminds me of what Selenium-Webdriver did for Node.js as well. (Read below).

But I am wondering if this library has plans to move to async/await instead of the homegrown flow control currently used. I like the methodology you used (is there a name for it?) but it's hard to mix other async flow control with your library.

For the record - selenium-webdriver did something similar to this library whereby every (async) call was put on a queue - they moved to promises (which will work with async await of course).

You can read about that here:
https://github.com/SeleniumHQ/selenium/wiki/WebDriverJs

and here:
https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/lib/promise.html

Might be a good excuse to update the lib, or maybe you'd recommend forking it and applying the changes if Mapbox doesn't see a need?

@agauniyal
Copy link

@ORESoftware this module is rarely updated, even useful PRs are pending for a long time so I don't see if you can get that change easily. Anyways you can use newer module - https://github.com/kriasoft/node-sqlite, which uses this one only underneath the hood.

@daniellockyer
Copy link
Member

daniellockyer commented Sep 15, 2022

I'd love to see a PR for this - Promises FTW!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants