Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redis5 in CI pipeline #6379

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Remove redis5 in CI pipeline #6379

merged 1 commit into from
Jun 27, 2024

Conversation

titpetric
Copy link
Contributor

@titpetric titpetric commented Jun 27, 2024 •
edited
Loading

It is what it is

@titpetric titpetric requested a review from a team as a code owner June 27, 2024 09:08
@github-actions GitHub Actions
Copy link
Contributor

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 2
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review Configuration Clarity:
The comments added to explain the limitations of the CI workflow are helpful, but they could be more concise and directive about the specific actions needed for future improvements.
Dependency Management:
Ensure that removing Redis 5 does not impact any backward compatibility or existing dependencies that might still rely on this version.

@github-actions GitHub Actions
Copy link
Contributor

API Changes

no api changes detected

@github-actions GitHub Actions
Copy link
Contributor

Failed to generate code suggestions for PR

@titpetric titpetric enabled auto-merge (squash) June 27, 2024 09:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@titpetric titpetric merged commit bf39a75 into master Jun 27, 2024
35 checks passed
@titpetric titpetric deleted the ci/adjust-ci-tests-conditions branch June 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffy-mathew jeffy-mathew jeffy-mathew approved these changes

@andrei-tyk andrei-tyk andrei-tyk approved these changes

Assignees
No one assigned
Labels
configuration changes enhancement Review effort [1-5]: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@titpetric @jeffy-mathew @andrei-tyk