Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDD-2219: Add TREND_LINE_NONE to simplified chart colours #1763

Closed
wants to merge 1 commit into from

Conversation

phill-stanley
Copy link
Contributor

@phill-stanley phill-stanley commented Sep 19, 2024

Description

This PR includes an update to the charts colour scheme to include a none trend line colour for charts that don't have trend data.

Fixes #CDD-2219


Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

Copy link

sonarcloud bot commented Sep 19, 2024

@phill-stanley
Copy link
Contributor Author

Screenshot 2024-09-19 at 08 38 04

@@ -21,6 +21,7 @@ class RGBAChartLineColours(Enum):
TREND_LINE_POSITIVE = 0, 112, 60
TREND_LINE_NEGATIVE = 171, 43, 23
TREND_LINE_NEUTRAL = 56, 63, 67
TREND_LINE_NONE = 17, 67, 110
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is meant to be a dark blue, then why haven't we used the existing COLOUR_1_DARK_BLUE rgb colour? That has already been user tested and approved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, checked with front-end and the COLOUR_1_DARK_BLUE is fine for this, will close this branch and update the alt-text branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants