Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/cdd 2220 update alt text for tend line none #1764

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Task/cdd 2220 update alt text for tend line none #1764

wants to merge 1 commit into from
+29 −1

Conversation

phill-stanley
Copy link
Contributor

@phill-stanley phill-stanley commented Sep 19, 2024 •
edited
Loading

Description

This PR includes an update to plots_text for when the simplified chart colour is TREND_LINE_NONE

Fixes #CDD-2220

Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@phill-stanley phill-stanley force-pushed the task/cdd-2220-update-alt-text-for-tend-line-none branch from 889c450 to a5ed085 Compare September 19, 2024 07:53
@phill-stanley
Copy link
Contributor Author

Screenshot 2024-09-19 at 08 54 32
Screenshot 2024-09-19 at 08 55 28

@phill-stanley phill-stanley changed the base branch from main to task/cdd-2219-update-simplified-chart September 19, 2024 08:00
@phill-stanley phill-stanley force-pushed the task/cdd-2220-update-alt-text-for-tend-line-none branch from a5ed085 to ff04677 Compare September 19, 2024 08:58
@phill-stanley phill-stanley changed the base branch from task/cdd-2219-update-simplified-chart to main September 19, 2024 08:58
@phill-stanley phill-stanley force-pushed the task/cdd-2220-update-alt-text-for-tend-line-none branch from ff04677 to 7ef044c Compare September 19, 2024 10:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Ashiq A-Ashiq A-Ashiq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phill-stanley @A-Ashiq