First iteration of air_quality API based on the temperature API #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've written the base of air_quality API, next I will add a fake sensor for testing the API, including unit testing for the fake sensor
|
Looks good, a few comments:
|
alexandruradovici
requested changes
Mar 27, 2023
I've removed the `AirQualityListener` and used a `Cell<Option<(u32,)>>` instead. I've added a private Enum for choosing what kind of data reading to execute, a private method that uses this Enum and two other public functions as wrappers.
I've added a fake `AirQuality` driver and some integration tests for it. Every test is passed and should reflect the behaviour of the real driver.
I've added unittests for each function of the AirQuality API, all pass as expected. Documentation for the API will be part of the next commit.
alexandruradovici
requested changes
Apr 9, 2023
Added the suggested changes, including the `read_sync` function that return a tuple of both CO2 and TVOC values. Improved the unittests for the fake driver and added a unittest for the new function.
alexandruradovici
previously approved these changes
Apr 18, 2023
|
The PR is on upstream: tock#464 |
alexandruradovici
added
upstream
I've added back the dedicated listener for this API and rewritten the returning errors of some functions.
I've added some documentation for the functions of the API and fixed an inclusion bug of the API in `tests.rs` that made the CI fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written the base of
air_qualityAPI. I will add documentation as I progress with this PR. I would be glad to receive feedback, mainly onread_data_sync.