SOLVING TODO: determine if this is necessary or not, since this breaks rm o…
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith user local environment
|
Please explain your pull request. |
|
@alexandruradovici done |
|
Use the 3rd person and make the text more visible (use lists, etc). |
|
@alexandruradovici done |
| @@ -72,10 +72,10 @@ macro_rules! nu { | |||
| // For all other options, we call `.into()` on the `$value` and hope for the best. ;) | |||
| ( | |||
| @options [ $($options:tt)* ] | |||
| $field:ident : $value:expr, | |||
| custom_plugin_path: $value:expr, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves:
the TODO in the
/crates/nu-test-support/src/macros.rsfile.Here, there was integrated an option to specify a custom plugin path in the 'nu_run_test' and
nu_with_plugin_run_testfunctions. This allows testing with plugins without affecting the user's local environment, ensuring a more controlled and isolated testing setup.Specifically, a custom_plugin_path field was added to the
NuOptsstruct and utilized within thenu_with_plugin_run_testfunction. If a custom plugin path is provided in the options, it's set as an environment variable for the command that runs the test. This modification enhances the flexibility and robustness of the testing environment in the Nushell.the TODO in the
/src/terminal.rsfile.Here, the signal(
SIGCHLD,SigHandler::SigIgn) call became conditional, by executing it only on non-macOS systems to avoid breaking the rm command on macOS.