Integer initialPosition coordinates in crazyflies.yaml #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be "squash and merge"d into one commit.
See motivating discussion in #380.
I wanted to add a CI test that starts the server and looks for the "Parsed crazyflies.yaml successfully" message on stdout before the server fails due to no radio or CFs existing. However, the server tries to open the radio on USB before it finishes parsing.
It would be nice if the config-parsing and hardware connection were two cleanly separated phases in the server, but the problem is that we initialize the
CrazyflieBroadcaster
member in the initializer list ofCrazyflieGroup
:crazyswarm/ros_ws/src/crazyswarm/src/crazyswarm_server.cpp
Line 810 in 957d663
To fix this enough for single-group testing, we would need to move the broadcaster initialization to the end of the
CrazyflieGroup
constructor, either by givingCrazyflieBroadcaster
a separate init method or using a pointer. However, to fix it enough for multi-group testing, we would need to giveCrazyflieGroup
itself a separate init method, so we can finish parsing for all of the channels before attempting to connect to any of them.I think this would be a design improvement, but maybe should be deferred until after the link-cpp version.