-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix two failing Python Tests on Ubuntu 20.04 #497
Conversation
* Update test_videoOutput to use the correct Python version * Add missing information to docs Fixes issue #496
@jpreiss Any idea how to fix those failing tests? It looks to me like ffmpeg-python simply doesn't work with Python2 anymore. |
It seems like Python 2 CI is failing on the installation of I think it's reasonable to leave video out of the standard Crazyswarm dependency list. The This is what I did for the ROS import test - see 402f099. |
I only added it to CI because it's missing in the documentation and the documentation is generated from CI ... Should we leave it out from the docs or have a separate manual line there? |
Yes, I was thinking of a separate line in the manual presented as an optional step. We never get issues/discussions about video output so I feel that most users do not use it. |
CI: * remove unused embedded gcc * avoid using sudo for pip (this was also causing the documentation to suggest using sudo, which is bad practice)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ffmpeg-python
accesses ffmpeg through the shell, so we might want to tell the user to sudo apt install -y ffmpeg
as well.
* Fix two failing Python Tests on Ubuntu 20.04 * Update test_videoOutput to use the correct Python version * Add missing information to docs * List ffmpeg-python and ffmpeg as optional dependency CI: * remove unused embedded gcc * avoid using sudo for pip (this was also causing the documentation to suggest using sudo, which is bad practice) Fixes issue IMRCLab#496
Fixes issue #496