fixing some autoconf problems #3022
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
requested review from
WardF and
DennisHeimbigner
as code owners
WardF
reviewed
Sep 12, 2024
| @@ -227,6 +227,8 @@ AC_MSG_RESULT($enable_dap) | |||
| if test "x$enable_remote_functionality" = xno ; then | |||
| AC_MSG_WARN([All network access is disabled => DAP support disabled.]) | |||
| enable_dap=no | |||
| AC_MSG_WARN([All network access is disabled => NCZARR support disabled.]) | |||
There was a problem hiding this comment.
Leaving nczarr enabled despite the lack of network access is currently what we'd like to do, although there will be a bigger task ahead of us regarding a separation of 'local-nczarr functionality' vs. 'remote data access functionality', in the code. It's why I've, for the upcoming release candidate, opted to leave libcurl as a dependency when nczarr is enabled. Maybe it's already handled, but I need to make sure nothing breaks if we compile nczarr support without linking libcurl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.