Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

so ADJ that ADVCL #106

Closed
amir-zeldes opened this issue Nov 18, 2020 · 6 comments
Closed

so ADJ that ADVCL #106

amir-zeldes opened this issue Nov 18, 2020 · 6 comments

Comments

@amir-zeldes
Copy link
Contributor

There is only one case of "so ADJ that ADVCL" annotated as such in the corpus:

  • seeing you so relaxed that you are sleeping/advcl will send the message that everything is OK

http://match.grew.fr/?corpus=UD_English-EWT@2.7&custom=5fb5361c6ef6b&eud=yes

But there are a few more which I think are incorrectly annotated as ccomp:

Some of these are false positives (adjectives introducing direct speech etc.), but a few have the same structure as the case above, for example:

  • Everyone was so helpful that I cannot wait/ccomp to go back ..... (should be be advcl?)

http://match.grew.fr/?corpus=UD_English-EWT@2.7&custom=5fb5353b66cc8&eud=yes

amir-zeldes added a commit to amir-zeldes/gum that referenced this issue Nov 18, 2020
@nschneid
Copy link
Contributor

Agreed, advcl seems sensible for clauses licensed by "so" (the degree-consequence construction).

"that" isn't actually required, so here's a broader query:

http://match.grew.fr/?corpus=UD_English-EWT@2.7&custom=5fb537e7b3d81&eud=yes

e.g. these demons are so GREEDY, they want as much of their "product" as they can get

I didn't find any "enough" + ccomp examples.

@amir-zeldes
Copy link
Contributor Author

Good point, just ran that search on GUM and corrected cases without "that" (see amir-zeldes/gum@81ee754 )

@manning
Copy link
Contributor

manning commented Dec 16, 2020

I agree that ccomp is wrong and advcl would be right!

@nschneid
Copy link
Contributor

Also: UniversalDependencies/docs#672

@nschneid
Copy link
Contributor

Updated queries:

@nschneid
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants