Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the advcl:relcl subtype #346

Closed
nschneid opened this issue Aug 2, 2022 · 6 comments
Closed

Adding the advcl:relcl subtype #346

nschneid opened this issue Aug 2, 2022 · 6 comments

Comments

@nschneid
Copy link
Contributor

nschneid commented Aug 2, 2022

It has been decided that relative clauses modifying entire clauses, not nominals, should no longer be acl:relcl: UniversalDependencies/docs#886

This issue is to track English-specific implementation

nschneid referenced this issue in amir-zeldes/gum Aug 2, 2022
@nschneid
Copy link
Contributor Author

nschneid commented Aug 2, 2022

@amir-zeldes How are you handling edeprels given the type mismatch of "which" (PRON) and its clausal antecedent? I am thinking nsubj/obj for "which" at the basic level and csubj/ccomp as the enhanced dependency for its antecedent.

@nschneid
Copy link
Contributor Author

nschneid commented Aug 2, 2022

@nschneid
Copy link
Contributor Author

nschneid commented Aug 3, 2022

Was surprised how few adverbial acl:relcls were in EWT—turns out most of the adverbial relatives were parataxis.
Need to go through:

nschneid added a commit that referenced this issue Aug 3, 2022
@nschneid
Copy link
Contributor Author

nschneid commented Aug 3, 2022

  • http://universal.grew.fr/?custom=62eaac2fdaf97: "which" marked as PronType=Int (the default for WH-pronouns) but not appearing in a typical relative clause context. Some are errors (ccomp should be advcl:relcl); some are relative clauses as full sentences, so should be PronType=Rel; others are truly interrogative. I will go through them and mark the truly interrogative ones with a MISC feature ManuallyChecked=PronType. (all addressed)

@amir-zeldes
Copy link
Contributor

some more GUM hits (as well as false positives) in: http://universal.grew.fr/?custom=62e9b21aa045b http://universal.grew.fr/?custom=62e9b7f6c21e5 http://universal.grew.fr/?custom=62e9b9167881c

Thanks for reporting, there were two instances I'd missed in there!

@amir-zeldes
Copy link
Contributor

amir-zeldes commented Aug 4, 2022

@amir-zeldes How are you handling edeprels given the type mismatch of "which" (PRON) and its clausal antecedent? I am thinking nsubj/obj for "which" at the basic level and csubj/ccomp as the enhanced dependency for its antecedent.

Yeah, that looks good, just implemented it. I also saw cases of obl ->advcl and even csubj:pass once...

(2nd part moved to other thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants