chore: Rust 1.81で追加された機能を利用する #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
force-pushed
the
chore-use-features-of-rust-1-81
branch
from
9bd038e
to
7e818b7
Compare
qryxip
commented
Sep 5, 2024
Comment on lines
-75
to
+78
| // https://crates.io/crates/rstest_reuse#use-rstest_resuse-at-the-top-of-your-crate | ||
| #[allow(clippy::single_component_path_imports)] | ||
| #[expect( | ||
| clippy::single_component_path_imports, | ||
| reason = "https://crates.io/crates/rstest_reuse/0.6.0#use-rstest_resuse-at-the-top-of-your-crate" | ||
| )] |
There was a problem hiding this comment.
rstest_reuse v0.7.0ではreadmeからこのセクションが消えてた、のですがクレートの構成が未だにproc-macro一本のまま。大丈夫になったとは思えないのですがなんで消しちゃったのかよくわからない…
la10736/rstest@aca3c60
There was a problem hiding this comment.
あ、もしかしたら「rstest_reuse自体の他のマクロ」を呼ばないような設計になったのかも。
qryxip
force-pushed
the
chore-use-features-of-rust-1-81
branch
from
7e818b7
to
60ee889
Compare
sevenc-nanashi
approved these changes
Sep 5, 2024
Hiroshiba
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Announcing Rust 1.81.0 | Rust Blog
#[allow(…)]を#[expect(…)]に置き換えます。不要になった警告抑制をすみやかに消せるようにするためです。non_camel_case_typesだけ、Rust Analyzerがまだ#[expect(…)]に対応していなくてClippyとは別に文句を言ってくるため#[allow(…)]のままにしています。[追記] test_utilで生成しているc_api.rsについても、OSによってbindgenの生成コードが変わって管理が面倒なので
#[expect(…)]にするのは諦めました。#[allow(…)],#[expect(…)],#[forbid(…)]のすべてにreason = "…"を書きます。allowとexpectのreasonをどういう文体で書くか迷ったのですが、コメントのような感じで書くことにしました。forbidの方はエラーメッセージとしての文体に。関連 Issue
Rust 1.81: #826
前回: #816
その他