feat(pdfjs): upgrade to v4 #1105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Hall <[email protected]>
|
Oh nice, I had thought that v4 would require substantive changes to the codebase but it seems the v3 changes were enough. Testing this locally things seem to work fine for me—great work. Ps. this also closes #1078 |
Yea it was thank you so much. Want to use this but hard time passing it through security :( even with your partial fix |
|
Was just about to start working on the v4 port, but then saw this pr. Thanks for the great work @Jordan-Hall and @shamoon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1093