Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update exclusion reasons #109

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

lishaduck
Copy link
Contributor

Status

READY

Description

See #107.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@lishaduck lishaduck requested a review from a team as a code owner August 18, 2024 21:39
@lishaduck
Copy link
Contributor Author

Do I need to update the readme, or should I let y'all do it with the next release?

@lishaduck lishaduck changed the title chore: update exclusion reasons docs: update exclusion reasons Aug 18, 2024
@alestiago
Copy link
Contributor

alestiago commented Aug 19, 2024

@lishaduck thanks for the documentation updates πŸ’™ . Feel free to update the README by running the tool with the current version.

It's fine to update the README before the next release, I believe the changes are documenting existing excluded rules.

Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the README, will like to get this merged to avoid future conflicts.

Thanks for the documentation!

@alestiago alestiago merged commit 4ec0f19 into VeryGoodOpenSource:main Aug 19, 2024
4 checks passed
@lishaduck lishaduck deleted the more-reasons branch August 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants