Spec the last() operator
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 3, 2024
See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 3, 2024
See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 3, 2024
See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 3, 2024
See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5417373 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1282037}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 3, 2024
See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5417373 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1282037}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 3, 2024
See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5417373 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1282037}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 10, 2024
…perator, a=testonly Automatic update from web-platform-tests DOM: Implement the `last()` Observable operator See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5417373 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1282037} -- wpt-commits: 66396b12b8f7aa4390fc9e6db826dfcec7f8ff2c wpt-pr: 45500
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Apr 15, 2024
…perator, a=testonly Automatic update from web-platform-tests DOM: Implement the `last()` Observable operator See WICG/observable#133. This CL implements the `last()` operator which returns a Promise that resolves to the last item that the source Observable emits, and rejects with a RangeError if the Observable completes prematurely. For WPTs: Co-authored-by: ben@benlesh.com R=dizhangg@chromium.org Bug: 40282760 Change-Id: Id1ec2af152c288ae81dfe383dfa9a7f166cfb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5417373 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1282037} -- wpt-commits: 66396b12b8f7aa4390fc9e6db826dfcec7f8ff2c wpt-pr: 45500
benlesh
approved these changes
Apr 18, 2024
domfarolino
added a commit
that referenced
this pull request
May 4, 2024
This reverts commit e6ee22b.
domfarolino
added a commit
that referenced
this pull request
May 4, 2024
This reverts commit e6ee22b.
github-actions bot
added a commit
that referenced
this pull request
May 4, 2024
SHA: abd795b Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff