Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent order of JSON nodes in .egn file makes diffing versions harder #161

Open
hofstef opened this issue Sep 24, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@hofstef
Copy link
Member

hofstef commented Sep 24, 2024

Describe the bug
When a domain story is exported multiple times, the sequence of the JSON nodes in the .egn file is different every time. This has no effect on the functionality of Egon (ie, importing still works fine and semantically, the stories are the same). But users who put their .egn files in a sourcecode repository like Git will have a hard time to see actual changes in their files.

This seems to happen only in Firefox, not Chrome.

To Reproduce
[If applicable, attach a .dst file. ]
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Click on '....'
  4. See error

Expected behavior

  • Only JSON nodes that have actually changed should be different from the previous .egn file.
  • Exporting the same Domain Story twice should result in the exact same .egn file.

Version

  • Egon: v2.1.0
  • Browser: Firefox
  • OS: Windows
@hofstef hofstef added the bug Something isn't working label Sep 24, 2024
@DanielHeckert DanielHeckert self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants