Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added jwt decoding #13

Merged
merged 6 commits into from
Mar 16, 2023
Merged

feat: added jwt decoding #13

merged 6 commits into from
Mar 16, 2023

Conversation

Rakowskiii
Copy link
Contributor

Description

Adding decoding and verification functionality for JWTs.
Follows the code from https://github.com/WalletConnect/rs-relay/blob/eaed61447e4d090ebdc8e036e8f6514680be0256/src/handler/publish.rs#L282 but adding more descriptive errors for JWT validation.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

heilhead
heilhead requested changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@heilhead heilhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please also port the relay's tests.

heilhead
heilhead reviewed Mar 16, 2023
View reviewed changes
relay_rpc/src/auth.rs Outdated Show resolved Hide resolved
@heilhead
Copy link
Collaborator

heilhead commented Mar 16, 2023 •
edited
Loading

Also, please rebase off the latest main, or otherwise cocogitto status won't be updated.

heilhead
heilhead approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@heilhead heilhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Rakowskiii Rakowskiii merged commit ced99e7 into main Mar 16, 2023
@Rakowskiii Rakowskiii deleted the feat/add-jwt-decoding branch March 16, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heilhead heilhead heilhead approved these changes

@HarryET HarryET HarryET approved these changes

@arein arein Awaiting requested review from arein

@xav xav Awaiting requested review from xav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rakowskiii @heilhead @HarryET