Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: web3modal siwe #26

Merged
merged 4 commits into from
Jul 2, 2024
Merged

fix: web3modal siwe #26

merged 4 commits into from
Jul 2, 2024

Conversation

alexsserban
Copy link
Contributor

  • allows non-tls on development environment
  • enforces sameSite: "strict" on all environments, as it is needed for local development as well
  • adds default expirationTime, as the SIWE message might not contain that (1CA)

@alexsserban alexsserban merged commit 2e4d25f into main Jul 2, 2024
alexsserban added a commit that referenced this pull request Jul 2, 2024
@alexsserban
fix: web3modal siwe (#26)
a9e35b0 
* fix: allow non-tls on dev

* fix: enforce sameSite:strict

* fix: add default expirationTime

* fix: use strict for non-preview
alexsserban added a commit that referenced this pull request Jul 2, 2024
@alexsserban
fix: rebase naming issues (#27)
16afc4d 
* fix(actions): sticking to the tag version instead of master branch in the shared GitHub action

* fix: web3modal siwe (#26)

* fix: allow non-tls on dev

* fix: enforce sameSite:strict

* fix: add default expirationTime

* fix: use strict for non-preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali93 Cali93 Cali93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsserban @Cali93