Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error when accessing window.localStorage #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borre-haechi
Copy link

Hello, we are using the wallet connect library successfully. However, we encountered an error during usage and have prepared a fix in the form of a pull request.

When using the wallet connect library in the iframe, accessing storage in incognito mode can be problematic. Specifically, reading window.localStorage within the iframe may throw an exception, especially when the "Block third-party cookies" option is turned on.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant