[spec] Clarify binary element bitfield meaning. #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the binary format, when treating the number distinguishing different kinds of element sections as a bitfield, the first bit distinguishes active segements from passive/declarative segments. The previous phrasing used "indicate" to mean that a 1 bit signifies "passive or declarative", however it is easy to misread this as passive and declarative referring to the two possible values of the bit instead. This change modifies the description of Bit 0 to make it clearer that it is differentiating active from passive or declarative, not passive from declarative, by using the "distinguishes ... from ..." language used in describing bit 1.
rossberg
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the binary format, when treating the number distinguishing different kinds of element sections as a bitfield, the first bit distinguishes active segements from passive/declarative segments.
The previous phrasing used "indicate" to mean that a 1 bit signifies "passive or declarative", however it is easy to misread this as passive and declarative referring to the two possible values of the bit instead.
This change modifies the description of Bit 0 to make it clearer that it is differentiating active from passive or declarative, not passive from declarative, by using the "distinguishes ... from ..." language used in describing bit 1.