Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit br return #2324

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dzfrias
Copy link
Contributor

@dzfrias dzfrias commented Nov 10, 2023

An in-progress fix for #2304. For now, I believe it's working for any br depth. However, I'm not really sure how to handle the br_if case. Should it be replaced with an if and then a return? If so, I couldn't really find a way to create a new IfExpr and compile that on the fly. Maybe someone with more experience with the decompiler source code has a good way to do it.

@keithw
Copy link
Member

keithw commented Nov 10, 2023

I think this PR probably makes you the leading active wasm-decompiler person we have. :-) Your strategy sounds good but I don't think I have any better ideas...

@dzfrias
Copy link
Contributor Author

dzfrias commented Nov 17, 2023

Hmm ok. I'll work on finding a solution that works, then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants