refactor the imports to its own world #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the imported APIs of http proxy to its own world, following the convention from other wasi proposals (e.g. https://github.com/WebAssembly/wasi-cli/blob/main/wit/imports.wit).
The intention of the
wasi:http/importsworld is to beincluded into other worlds such aswasi:http/proxyandwasi:cloud-core/imports.Suprisingly, I wasn't expecting there to be such a huge change to the markdown files. It seems like part of the reason is that the imported interfaces are unordered?