fix shared library build with llvm-19 #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* for non libc.so libraries, don't forget to link libc.so * avoid link errors on linker-provided symbols. i feel this is a workaround for a wasm-ld bug.
|
I'm seeing the following error when integrating it into a In the build directory, I wonder why the path mismatch didn't happen before this patch though.. |
when building a shared library, specify all CFLAGS because it can contain options like -resource-dir.
i pushed a commit which might fix it. |
|
Thanks, I've verified it fixes wasi-sdk build. |
TerrorJack
approved these changes
Aug 13, 2024
sbc100
reviewed
Aug 13, 2024
| @@ -0,0 +1,3 @@ | |||
| __heap_base | |||
| __heap_end | |||
| __c_longjmp | |||
There was a problem hiding this comment.
Can you open a wasm-ld bug regarding this? I think these should not be necessary.
Also, perhaps add a comment here (or in the Makefile) with a link the bug so we know its temporary.
There was a problem hiding this comment.
sbc100
reviewed
Aug 13, 2024
sbc100
approved these changes
Aug 14, 2024
yamt
added a commit
to yamt/wasi-libmalloc
that referenced
this pull request
Aug 16, 2024
230d4be6c54bec93181050f9e25c87150506bdd0 plus WebAssembly/wasi-libc#526
yamt
added a commit
to yamt/wasi-sdk
that referenced
this pull request
Aug 23, 2024
yamt
added a commit
to yamt/wasi-sdk
that referenced
this pull request
Aug 23, 2024
In the wasi-sdk windows job, when building libc.so, for some reasons, the -isystem option in CFLAGS here seems to prevent the linker from finding compiler-rt. I don't understand how it happens because: * Afaik, -isystem should not affect how the linker search objects * The compiler-rt path is explicitly given as BUILTINS_LIB Anyway, this commit tries to work it around by passing only a subset of the options.
yamt
added a commit
to yamt/wasi-sdk
that referenced
this pull request
Aug 28, 2024
For following changes: * WebAssembly/wasi-libc#526 * WebAssembly/wasi-libc#529
yamt
added a commit
to yamt/wasi-sdk
that referenced
this pull request
Sep 18, 2024
For following changes: * WebAssembly/wasi-libc#526 * WebAssembly/wasi-libc#529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.