Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Card heading level #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mediaformat
Copy link

@mediaformat mediaformat commented Feb 9, 2023

DESCRIPTION

  • Add a heading_level parameter to increase reusability, defaults to previous level 2

OTHER

  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

STEPS TO VERIFY

How do we test this?

  1. Call print_module() with or without a 'heading_level' parameter
print_module(
	'card',
	[
		'src'           => get_the_post_thumbnail_url( $scb_example_post->ID ),
		'eyebrow'       => esc_html( get_term( yoast_get_primary_term_id( 'category', $scb_example_post->ID ) )->name ),
		'heading'       => esc_html( $scb_example_post->post_title ),
		'heading_level' => 3,
	]
);

Add a heading_level parameter to increase utility, defaults to previous level 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant