Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Commit

Permalink
Merge pull request #237 from Wikia/XW-4231
Browse files Browse the repository at this point in the history
XW-4231 | Captions menu
  • Loading branch information
xkxd committed Nov 13, 2017
2 parents 5ba33bc + df76a0a commit 03f77f8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
14 changes: 7 additions & 7 deletions app/components/article-featured-video-jwplayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ export default Component.extend({
onCreate(player) {
this.player = player;

this.player.on('autoplayToggle', (data) => {
this.setCookie(this.get('autoplayCookieName'), data.enabled);
this.player.on('autoplayToggle', ({enabled}) => {
this.setCookie(this.get('autoplayCookieName'), (enabled ? '1' : '0'));
});

this.player.on('captionsSelected', (data) => {
this.setCookie(this.get('captionsCookieName'), data.enabled);
this.player.on('captionsSelected', ({selectedLang}) => {
this.setCookie(this.get('captionsCookieName'), selectedLang);
});
},

Expand All @@ -54,7 +54,7 @@ export default Component.extend({
const model = this.get('model.embed'),
jsParams = {
autoplay: $.cookie(this.get('autoplayCookieName')) !== '0',
captions: $.cookie(this.get('captionsCookieName')) !== '0',
selectedCaptionsLanguage: $.cookie(this.get('captionsCookieName')),
adTrackingParams: {
adProduct: this.get('ads.noAds') ? 'featured-video-no-preroll' : 'featured-video-preroll',
slotName: 'FEATURED'
Expand All @@ -79,8 +79,8 @@ export default Component.extend({
}
},

setCookie(cookieName, condition) {
$.cookie(cookieName, condition ? '1' : '0', {
setCookie(cookieName, cookieValue) {
$.cookie(cookieName, cookieValue, {
expires: this.get('playerCookieExpireDays'),
path: '/',
domain: config.cookieDomain
Expand Down
6 changes: 2 additions & 4 deletions app/modules/video-players/jwplayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,9 @@ export default class JWPlayer extends BasePlayer {
},
settings: {
showAutoplayToggle: true,
showCaptionsToggle: true
},
captions: {
enabled: this.params.captions
showCaptions: true
},
selectedCaptionsLanguage: this.params.selectedCaptionsLanguage,
autoplay: this.params.autoplay,
mute: this.params.autoplay,
related: {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"express-bunyan-logger": "1.3.2",
"fastboot": "github:wikia/fastboot#582162a5e2eb39c2d94f857e53ee0efff4544447",
"fastboot-app-server": "1.0.1",
"jwplayer-fandom": "github:wikia/jwplayer-fandom#1.0.19",
"jwplayer-fandom": "github:wikia/jwplayer-fandom#1.0.20",
"method-override": "2.3.10",
"on-headers": "1.0.1",
"snyk": "^1.41.1"
Expand Down

0 comments on commit 03f77f8

Please sign in to comment.