Merge pull request #269 from Wikia/render-hack-fix

Component rendering quick fix -- to preview

app/instance-initializers/error-logger.js

@@ -1,30 +1,14 @@
-import config from '../config/environment';
-import fetch from 'fetch';
+import logEvent from '../modules/event-logger';
 import Ember from 'ember';
 
 export function initialize(/* appInstance */) {
 	if (typeof FastBoot !== 'undefined') {
 		return;
 	}
-
 	Ember.onerror = function (error) {
-		const url = `https://${config.services.domain}/${config.services.eventLogger.baseAPIPath}/error`;
-
-		fetch(url, {
-			method: 'POST',
-			headers: {
-				'Content-Type': 'application/json'
-			},
-			// sends cookie with request, allows for logging beaconId and sessionId
-			credentials: 'include',
-			body: JSON.stringify({
-				name: 'Ember.onerror',
-				description: JSON.stringify({
-					message: error.message,
-					stack: error.stack,
-				}),
-				client: 'mobile-wiki'
-			})
+		logEvent('Ember.onerror', {
+			message: error.message,
+			stack: error.stack,
 		});
 
 		// To be able to display it in console

app/modules/event-logger.js

@@ -0,0 +1,20 @@
+import config from '../config/environment';
+import fetch from 'fetch';
+
+const url = `https://${config.services.domain}/${config.services.eventLogger.baseAPIPath}/error`;
+
+export default function logEvent(name, description) {
+	fetch(url, {
+		method: 'POST',
+		headers: {
+			'Content-Type': 'application/json'
+		},
+		// sends cookie with request, allows for logging beaconId and sessionId
+		credentials: 'include',
+		body: JSON.stringify({
+			name,
+			description: JSON.stringify(description),
+			client: 'mobile-wiki'
+		})
+	});
+}

app/utils/render-component.js

@@ -2,6 +2,7 @@ import {scheduleOnce} from '@ember/runloop';
 import $ from 'jquery';
 import {assert} from '@ember/debug';
 import {getOwner} from '@ember/application';
+import logEvent from '../modules/event-logger';
 
 function componentAttributes(element) {
 	const attrsJSON = element.getAttribute('data-attrs');
@@ -43,8 +44,15 @@ export function getRenderComponentFor(parent) {
 		componentInstance.renderer.appendTo(componentInstance, placeholderElement.parentNode);
 
 		scheduleOnce('afterRender', this, () => {
-			placeholderElement.parentNode.insertBefore(componentInstance.element, placeholderElement);
-			$(placeholderElement).remove();
+			if (componentInstance.element instanceof Node) {
+				placeholderElement.parentNode.insertBefore(componentInstance.element, placeholderElement);
+				$(placeholderElement).remove();
+			} else {
+				logEvent('render-component--element', {
+					componentName: name,
+					componentInstanceElement: JSON.stringify(componentInstance.element),
+				});
+			}
 		});
 
 		return componentInstance;