Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

adding some latam countries #2389

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

adding some latam countries #2389

wants to merge 1 commit into from

Conversation

unijuglr
Copy link
Contributor

@unijuglr unijuglr commented Nov 4, 2020

Links

Description

A description written using complete sentences of the changes being made and any context necessary to understand them.

Reviewers

Use @ mentions here. Alternatively, assign the pull request to a person.
@Wikia/cake

cschucode
cschucode reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@cschucode cschucode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these units the same for all the countries but "BR" : Brazil? If so, can't we use one unit and combine the countries?

i.e. "country": ["AR", "CL", "CO", "MX", "PE"]

I see. looks like the link params are country specific.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaRogan JoshuaRogan JoshuaRogan approved these changes

@cschucode cschucode cschucode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unijuglr @JoshuaRogan @cschucode