Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user wont be logged in before migration ends #2537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ludwikkazmierczak
Copy link
Contributor

No description provided.

article.verifyUserLoggedIn(credentials.userName10);
// Caused by: https://wikia-inc.atlassian.net/browse/PLATFORM-3829
// User wont be logged in after the migration is finished, since we are not going to sync access token over in CNW
// TODO: Enable once wikia.com -> fandom.com migration is complete

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO Complete the task associated to this TODO comment. rule

@WikiaTech
Copy link

SonarQube analysis reported 2 issues

  • MAJOR 1 major
  • INFO 1 info

Watch the comments in this conversation to review them.

// Caused by: https://wikia-inc.atlassian.net/browse/PLATFORM-3829
// User wont be logged in after the migration is finished, since we are not going to sync access token over in CNW
// TODO: Enable once wikia.com -> fandom.com migration is complete
// article.verifyUserLoggedIn(credentials.userName10);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR This block of commented-out lines of code should be removed. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants