Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all traces of reflection in ObjectSnapshot #34

Closed
wants to merge 4 commits into from

Conversation

Taluu
Copy link
Contributor

@Taluu Taluu commented Dec 25, 2015

Merry christmas @krichprollsch and @lunika, if this works as it should... ❤️

Basically, removing all traces or dependencies towards Reflection for an ObjectSnapshot. Need to create more tests though with actual objects (see https://gist.github.com/Taluu/2ed4d1d71d5c0db291c4#gistcomment-1657274)

  • Remove Reflection stuff
  • Add some tests for private / protected properties

It's a little bit hackish though, even though it is still far more optimized like this.

@Taluu
Copy link
Contributor Author

Taluu commented Dec 26, 2015

https://blackfire.io/profiles/compare/e3790154-b2fc-4fa8-b7cd-ed99f55fd271/graph Here is a comparision before / after. Basically, it's about 20 to 40% better :}

@Taluu
Copy link
Contributor Author

Taluu commented Dec 27, 2015

Closing, as the target has changed (1.x instead of master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant