SandBox: Convert to TypeScript #46478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Dec 12, 2022
| @@ -1,4 +1,4 @@ | |||
| # Sandbox | |||
| # SandBox | |||
There was a problem hiding this comment.
The public export is capitalized as "SandBox", so I've fixed up the capitalization inconsistencies.
|
Size Change: +57 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Jan 6, 2023
| @@ -83,6 +88,7 @@ const observeAndResizeJS = function () { | |||
| window.addEventListener( 'resize', sendResize, true ); | |||
| }; | |||
|
|
|||
| // TODO: These styles shouldn't be coupled with WordPress. | |||
| const { contentDocument, ownerDocument } = ref.current; | ||
| const { body } = contentDocument; | ||
| const { contentDocument, ownerDocument } = | ||
| ref.current as HTMLIFrameElement & { |
There was a problem hiding this comment.
Just to be explicit, we are sure that ref.current is not undefined because isFrameAccessible acts as a typeguard
ciampo
reviewed
Jan 6, 2023
packages/components/CHANGELOG.md
Outdated
| @@ -42,6 +42,7 @@ | |||
| - NumberControl: refactor styles/tests/stories to TypeScript, replace fireEvent with user-event ([#45990](https://github.com/WordPress/gutenberg/pull/45990)). | |||
| - `useBaseField`: Convert to TypeScript ([#45712](https://github.com/WordPress/gutenberg/pull/45712)). | |||
| - `Dashicon`: Convert to TypeScript ([#45924](https://github.com/WordPress/gutenberg/pull/45924)). | |||
| - `SandBox`: Convert to TypeScript ([#46478](https://github.com/WordPress/gutenberg/pull/46478)). | |||
There was a problem hiding this comment.
This line may need to be moved up after rebasing
The public export is capitalized as "SandBox"
|
Flaky tests detected in 6b3b3e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3859426269
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35744
What?
Add TypeScript types and documentation to the
SandBoxcomponent.Why?
So we can ship TS data with the wp-components package.
Testing Instructions
npm run storybook:devSandBoxshould look good, and the prop descriptions should match the README.md.