FontSizePicker: use CustomSelectControl V2 legacy adapter #63134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
85 tasks
ciampo
added
[Type] Enhancement
ciampo
commented
Jul 4, 2024
Comment on lines
116
to
126
| <Styled.SelectLabel | ||
| store={ store } | ||
| render={ | ||
| hideLabelFromVision ? ( | ||
| // @ts-expect-error `children` are passed via the render prop | ||
| <VisuallyHidden as="label" /> | ||
| ) : undefined | ||
| } | ||
| > | ||
| { label } | ||
| </Styled.SelectLabel> |
|
Size Change: +683 B (+0.04%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/custom-select-control-v2-adapter/font-size-picker
branch
from
cba82e1
to
d596eb6
Compare
|
Merged #63137 and rebased on top of latest |
tyxla
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Code is straightforward and looks good.
Behavior-wise, things are working well both in Storybook and in the editor.
I'm noticing subtle spacing differences between trunk and this branch, are they expected? You might have to compare them screen to screen to see them.
trunk:
this branch:
|
The main differences that I notice:
In my opinion:
I believe we can merge this PR, and address any potential further design feedback separately. |
mirka
approved these changes
Jul 8, 2024
tyxla
approved these changes
Jul 8, 2024
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
…63134) * FontSizePicker: use CustomSelectControl V2 legacy adapter * CHANGELOG * Fix unit tests * Update e2e tests --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…63134) * FontSizePicker: use CustomSelectControl V2 legacy adapter * CHANGELOG * Fix unit tests * Update e2e tests --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #55023
Requires #63131 and #63137 to be merged first
Replace the V1
CustomSelectControlwith the V2 legacy adapter in theFontSizePickercomponent.Why?
The goal is to ultimately replace the legacy V1 implementation entirely with the V2 legacy adapter. We're performing the migration gradually, and fixing any bugs / gaps as we go.
How?
comboboxrole instead ofbuttonTesting Instructions
Note:
FontSizePickershows aCustomSelectControlonly when there are more than 5 predef font sizes for the use user to choose from. In the case of 5 or less predef font size, aToggleGroupControlis shown.FontSizePickerstorybook examplestrunktheme.jsonfile and make sure that there are 6 predef font sizes or moretrunkcscv2.font.picker.global.styles.v1.mp4
cscv2.font.picker.global.styles.v2.mp4