Update turbopack-nightly-release.yml #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Windows sorts the environment variables returned, breaking snapshot tests.
ast-grep[0] is a tool that uses tree-sitter[1] and a pattern language to
match against code using its ast. It implements code transformation,
querying, and linting.
Since clippy isn't extensible for project-specific lints, this adds a
first ast-grep lint disallowing `context` as a variable name. Currently
it's set to warning as usage is addressed.
To run, install ast-grep, then run `ast-grep scan`. Example output:
```
warning[no-context]: Don't name variables `context`.
┌─ ./crates/turbopack-ecmascript-hmr-protocol/src/lib.rs:132:9
│
132 │ pub context: &'a str,
│ ----^^^^^^^---------
│
= Use a more specific name, such as chunking_context, asset_context, etc.
```
[0] https://ast-grep.github.io
[1] https://tree-sitter.github.io/tree-sitter/
### Description switch the daily next integration test run to use `--experimental-turbo`
### Description The Vc update broke some tracing span names
…rcel#5597) This implements build minification for turbopack-cli build and on the node build chunking context, using swc minify. It required adapting swc's public minification code to produce `SourceMap`s to avoid generating and re-parsing source maps. Test Plan: Input: `src/index.js`: ``` let myVar = 3; console.log("foo", myVar); ``` Output: ``` module.exports={"[output]/src/index.js (ecmascript)":function({r:__turbopack_require__,f:__turbopack_require_context__,i:__turbopack_import__,s:__turbopack_esm__,v:__turbopack_export_value__,n:__turbopack_export_namespace__,c:__turbopack_cache__,l:__turbopack_load__,j:__turbopack_dynamic__,g:global,__dirname,m:module,e:exports}){function(){console.log("foo",3)}.call(this)}}; //# sourceMappingURL=[output]_src_index_e254c5.js.map ``` - Verified source map matched input tokens.
Signed-off-by: Ethereum <136061549+sammyfilly@users.noreply.github.com>
### Description Update `swc_core` to swc-project/swc@00a0575 ### Testing Instructions See vercel/next.js#53308 --- Closes WEB-1327
### Description Ported both of these and connected to the run outline. I eschewed using a trait because the function signatures are not identical between `fs` and `http`, plus it's only two caches so there's no need for too much abstraction. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: nicholaslyang <Nicholas Yang>
### Description sync next.js and turbo
This migrates some crates away from using `context`, specifically: - `node-file-trace` - `turbo-tasks-build` - `turbo-tasks-fetch` - `turbo-tasks` - `turbopack-build` - `turbopack-cli-utils` - `turbopack-cli` - `turbopack-core` - `turbopack-ecmascript` This also moves the lint to `error` and ignores other failing crates.
This migrates `turbopack-core` to the no-context rule. Notably, this addresses an issue where function names were not caught and renames `Issue`'s `context` method to `file_path`.
Signed-off-by: Ethereum <136061549+sammyfilly@users.noreply.github.com>
|
OJ Kwon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions