Pin protobuf packages #3715
Merged
Pin protobuf packages #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happened in the past that I ran with the wrong protobuf version installed locally, and apparently there is even still some file wrong in splithttp. Fix this issue once and for all.
|
I think we should treat it like other dependencies and keep promote latest. |
|
I bumped the version to latest and regenerated all the files, but I still think the version should be pinned. Currently the experience for new contributors is broken because the latest protoc-gen-grpc version introduced some breaking changes. |
|
Thanks! Let's merge it for now. I may need to change to reference master later.. |
GFW-knocker
added a commit
to GFW-knocker/Xray-core
that referenced
this pull request
Aug 26, 2024
This reverts commit 2be03c5.
zxspirit
pushed a commit
to zxspirit/Xray-core
that referenced
this pull request
Aug 30, 2024
* Pin protobuf packages It happened in the past that I ran with the wrong protobuf version installed locally, and apparently there is even still some file wrong in splithttp. Fix this issue once and for all. * bump protobuf packages * Revert "bump protobuf packages" This reverts commit 7a35093. * Revert "Revert "bump protobuf packages"" This reverts commit bb79707. * fix deprecated grpc usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happened in the past that I ran with the wrong protobuf version installed locally, and apparently there is even still some file wrong in splithttp. Fix this issue once and for all.