Skip to content

Commit

Permalink
Update MongoDB.Driver Package Version To 2.28.0 (#2266)
Browse files Browse the repository at this point in the history
* Update MongoDB.Driver package version to 2.28.0

* remove SignAssembly
  • Loading branch information
Alirexaa committed Jul 30, 2024
1 parent eec153e commit 65ab619
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/HealthChecks.MongoDb/HealthChecks.MongoDb.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="MongoDB.Driver" Version="2.22.0" />
<PackageReference Include="MongoDB.Driver" Version="2.28.0" />

This comment has been minimized.

Copy link
@ChrisMcKee

ChrisMcKee Aug 8, 2024

Wouldn't this be better set using a more flexible version like Version="[2.22,)" ?

This comment has been minimized.

Copy link
@ledouxpl

ledouxpl Aug 13, 2024

It could use flexible version, but then it would need to set 2.28.0 as the minimal version to use since this is the version where MongoDB started strong naming their assemblies. See https://www.mongodb.com/community/forums/t/net-c-driver-strong-naming/291649/15

<PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="8.0.0" />
</ItemGroup>

Expand Down
1 change: 0 additions & 1 deletion src/HealthChecks.UI/HealthChecks.UI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<VersionPrefix>$(HealthCheckUI)</VersionPrefix>
<TypeScriptCompileBlocked>True</TypeScriptCompileBlocked>
<WarningsNotAsErrors>$(WarningsNotAsErrors);RCS1090</WarningsNotAsErrors>
<SignAssembly>false</SignAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit 65ab619

Please sign in to comment.