Ensure all HealthChecks libraries have a .NETCoreApp TFM. #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that when libraries and apps who depend on the HealthChecks libraries get the correct transitive dependences for .NETCoreApp TFMs (for example Microsoft.Bcl.AsyncInterfaces). This follows the following [guidance](https://learn.microsoft.com/dotnet/standard/library-guidance/cross-platform-targeting): ✔️ CONSIDER multi-targeting even if your source code is the same for all targets, when your project has any library or package dependencies. Fix #2180 Fix #2084 Fix #2163
github-actions
bot
added
sqlserver
system
oracle
datadog
applicationinsights
cloudwatch
labels
adamsitnik
approved these changes
Apr 2, 2024
src/HealthChecks.System/DependencyInjection/SystemHealthCheckBuilderExtensions.cs
Show resolved
Hide resolved
|
LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
+ Coverage 64.11% 66.73% +2.62%
==========================================
Files 248 154 -94
Lines 8359 3547 -4812
Branches 586 374 -212
==========================================
- Hits 5359 2367 -2992
+ Misses 2852 1101 -1751
+ Partials 148 79 -69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that when libraries and apps who depend on the HealthChecks libraries get the correct transitive dependences for .NETCoreApp TFMs (for example Microsoft.Bcl.AsyncInterfaces).
This follows the following guidance:
✔️ CONSIDER multi-targeting even if your source code is the same for all targets, when your project has any library or package dependencies.
Fix #2180
Fix #2084
Fix #2163
cc @DamianEdwards