Merge pull request #1601 from YaleSTC/1600_refactor_eq_models_model_spec

[1600] Refactor Equipment Model Model Spec

app/controllers/equipment_models_controller.rb

@@ -160,9 +160,9 @@ def equipment_model_params
     # to resolve test failures)
     params.require(:equipment_model)
           .permit(:name, :category_id, :category, :description, :late_fee,
-                  :replacement_fee, :max_per_user, :document_attributes,
-                  :deleted_at, :photo, :documentation, :max_renewal_times,
-                  :max_renewal_length, :renewal_days_before_due, :late_fee_max,
+                  :replacement_fee, :max_per_user, :deleted_at, :photo,
+                  :documentation, :max_renewal_times, :max_renewal_length,
+                  :renewal_days_before_due, :late_fee_max,
                   { associated_equipment_model_ids: [] }, :requirement_ids,
                   :requirements, :max_checkout_length)
           .tap do |whitelisted|

app/models/equipment_model.rb

@@ -124,15 +124,6 @@ def normalized_photo_name
     "#{id}-#{photo_file_name.gsub(/[^a-zA-Z0-9_\.]/, '_')}"
   end
 
-  ###################
-  ## Class Methods ##
-  ###################
-
-  # TODO: this appears to be dead code - verify and remove
-  def self.select_options
-    order('name ASC').collect { |item| [item.name, item.id] }
-  end
-
   ######################
   ## Instance Methods ##
   ######################
@@ -159,13 +150,6 @@ def maximum_renewal_days_before_due
     renewal_days_before_due || category.maximum_renewal_days_before_due
   end
 
-  # TODO: This appears to be dead code, verify and delete
-  def document_attributes=(document_attributes)
-    document_attributes.each do |attributes|
-      documents.build(attributes)
-    end
-  end
-
   def active_reservations
     if AppConfig.check :requests_affect_availability
       reservations.not_overdue.active_or_requested