Fix ElementNotFound feature test intermittent failure

Resolves #1514
  - Only create a second equipment model and item when necessary in
    feature specs
  - Replace nearly all AppConfig creations in tests with a mocked
    AppConfig
  - Get rid of most before(:all) callbacks
  - Minor refactor of a reservations controller spec

spec/controllers/announcements_controller_spec.rb

@@ -11,9 +11,7 @@
 end
 
 describe AnnouncementsController, type: :controller do
-  before(:all) do
-    @app_config = FactoryGirl.create(:app_config)
-  end
+  before(:each) { mock_app_config }
 
   describe 'with admin' do
     before do

spec/controllers/app_configs_controller_spec.rb

@@ -135,9 +135,6 @@
       end
     end
     context 'app_config does not exist yet' do
-      before(:all) do
-        AppConfig.destroy_all
-      end
       before(:each) do
         sign_in FactoryGirl.create(:user)
         post :update

spec/controllers/blackouts_controller_spec.rb

@@ -11,9 +11,7 @@
 end
 
 describe BlackoutsController, type: :controller do
-  before(:all) do
-    @app_config = FactoryGirl.create(:app_config)
-  end
+  before(:each) { mock_app_config }
 
   describe 'with admin' do
     before do

spec/controllers/categories_controller_spec.rb

@@ -1,10 +1,8 @@
 require 'spec_helper'
 
 describe CategoriesController, type: :controller do
-  before(:all) do
-    @app_config = FactoryGirl.create(:app_config)
-  end
   before(:each) do
+    mock_app_config
     @category = FactoryGirl.create(:category)
   end
 
@@ -186,7 +184,4 @@
       end
     end
   end
-  after(:all) do
-    @app_config.destroy
-  end
 end

spec/controllers/contact_controller_spec.rb

@@ -1,12 +1,14 @@
 require 'spec_helper'
 
 describe ContactController, type: :controller do
-  before(:all) do
-    @app_config = FactoryGirl.create(:app_config)
-  end
   before(:each) do
     @category = FactoryGirl.create(:category)
     sign_in FactoryGirl.create(:user)
+
+    # goes after the above to skip certain user validations
+    @ac = mock_app_config(contact_email: 'contact@email.com',
+                          admin_email: 'admin@email.com',
+                          site_title: 'Reservations Specs')
   end
   describe 'GET new' do
     before(:each) do
@@ -48,8 +50,8 @@
   end
   context 'with contact e-mail set' do
     before do
-      AppConfig.first
-        .update_attributes(contact_link_location: 'contact@example.com')
+      allow(@ac).to receive(:contact_link_location)
+        .and_return('contact@example.com')
       post :create, message: FactoryGirl.attributes_for(:message)
     end
 
@@ -60,7 +62,7 @@
   end
   context 'with contact e-mail not set' do
     before do
-      AppConfig.first.update_attributes(contact_link_location: '')
+      allow(@ac).to receive(:contact_link_location).and_return('')
       post :create, message: FactoryGirl.attributes_for(:message)
     end
 
@@ -69,7 +71,4 @@
         include(AppConfig.first.admin_email)
     end
   end
-  after(:all) do
-    @app_config.destroy
-  end
 end

spec/controllers/equipment_items_controller_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe EquipmentItemsController, type: :controller do
-  before(:all) { @app_config = FactoryGirl.create(:app_config) }
+  before(:each) { mock_app_config }
   let!(:item) { FactoryGirl.create(:equipment_item) }
   let!(:deactivated_item) { FactoryGirl.create(:deactivated) }
 
@@ -342,6 +342,4 @@
       end
     end
   end
-
-  after(:all) { @app_config.destroy }
 end

spec/controllers/equipment_models_controller_spec.rb

@@ -105,7 +105,7 @@
 end
 
 describe EquipmentModelsController, type: :controller do
-  before(:all) { @app_config = FactoryGirl.create(:app_config) }
+  before(:each) { mock_app_config }
   let!(:model) { FactoryGirl.create(:equipment_model) }
 
   it_behaves_like 'calendarable', EquipmentModel
@@ -415,6 +415,4 @@
       end
     end
   end
-
-  after(:all) { @app_config.destroy }
 end

spec/controllers/import_users_controller_spec.rb

@@ -15,9 +15,7 @@
 end
 
 describe ImportUsersController, type: :controller do
-  before(:all) do
-    @app_config = FactoryGirl.create(:app_config)
-  end
+  before(:each) { mock_app_config }
 
   before(:each) do
     sign_in FactoryGirl.create(:admin)

spec/controllers/reports_controller_spec.rb

@@ -2,20 +2,17 @@
 
 describe ReportsController, type: :controller do
   before(:all) do
-    @app_config = FactoryGirl.create(:app_config)
     @user = FactoryGirl.create(:user)
     @banned = FactoryGirl.create(:banned)
     @checkout_person = FactoryGirl.create(:checkout_person)
     @admin = FactoryGirl.create(:admin)
   end
 
-  after(:all) do
-    AppConfig.delete_all
-    User.delete_all
-  end
-
   context 'as admin user' do
-    before(:each) { sign_in @admin }
+    before(:each) do
+      mock_app_config
+      sign_in @admin
+    end
 
     describe 'PUT /reports/update' do
       it 'defaults to the past year without a session or params' do

spec/controllers/requirements_controller_spec.rb

@@ -4,10 +4,8 @@
 # -- namely, it was necessary to test two contexts for each method: the user
 # being an admin, and not.
 describe RequirementsController, type: :controller do
-  before(:all) do
-    @app_config = FactoryGirl.create(:app_config)
-  end
   before(:each) do
+    mock_app_config
     @requirement = FactoryGirl.create(:requirement, contact_name: 'Adam Bray')
   end
   describe 'GET index' do
@@ -212,7 +210,4 @@
       end
     end
   end
-  after(:all) do
-    @app_config.destroy
-  end
 end