Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Open requests being included in missed reservation e-mails #1031

Closed
orenyk opened this issue Oct 22, 2014 · 0 comments · Fixed by #1115
Closed

Open requests being included in missed reservation e-mails #1031

orenyk opened this issue Oct 22, 2014 · 0 comments · Fixed by #1115

Comments

@orenyk
Copy link
Contributor

orenyk commented Oct 22, 2014

From BMEC:

Just thought I'd bring this to your attention. It's not a HUGE problem, but in the interest of making Reservations as usable as possible, I thought you'd want to know that patrons receive emails from Reservations when unapproved (note, not rejected) reservation requests are missed. That is, if a patron requests a reservation and that reservation isn't approved or rejected by the start date of the request, they'll get a "missed reservation" email. This probably won't happen TOO often, but I thought it might be something you'd want to fix for aesthetics more than anything else.

We need to fix the query that is triggered in the missed reservation email task to disregard pending requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants