Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Authentication initializer not actually working #1324

Closed
orenyk opened this issue Oct 18, 2015 · 1 comment
Closed

Authentication initializer not actually working #1324

orenyk opened this issue Oct 18, 2015 · 1 comment
Assignees
@orenyk
Labels
diff: 1 pri: 5 type: bug
Milestone
5.4.0

Comments

@orenyk
Copy link
Contributor

orenyk commented Oct 18, 2015

Turns out my authentication initializer fix in #1282 doesn't work - figured this out while testing #1127. I can push a quick fix now; not sure if I can test it since the initializer will have already run when the test suite starts up. Whoops!
@orenyk orenyk self-assigned this Oct 18, 2015
@orenyk orenyk added this to the 5.4.0 milestone Oct 18, 2015
@orenyk
Copy link
Contributor Author

orenyk commented Oct 18, 2015

This also would have prevented us from catching #1320 since it would have appropriately copied the cas_login parameter into the username column when Rails started.

orenyk added a commit that referenced this issue Oct 18, 2015
@orenyk
Actually fix authentication initializer
5fe0d72 
Resolves #1324 (and #1282 for real)
@orenyk orenyk mentioned this issue Oct 18, 2015
Merged
orenyk added a commit that referenced this issue Oct 20, 2015
@orenyk
Actually fix authentication initializer
f97e9f9 
Resolves #1324 (and #1282 for real)
- ensures that authentication initializer actually runs
- ensures that username is copied to cas_login during migration if
  necessary
orenyk added a commit that referenced this issue Oct 27, 2015
@orenyk
Add #1324
8e52378
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@orenyk orenyk

Labels
diff: 1 pri: 5 type: bug
Projects
None yet
Milestone
5.4.0
Development

No branches or pull requests
1 participant
@orenyk