You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
IMO we should consolidate is_banned, is_admin, is_checkout_person into:
type => 'admin', 'checkout', 'normal', or 'banned'
This way we could avoid the ludicrous (although theoretically possible) situations of Banned-Admins and Admin-Checkoutpersons (there might be a validation against these??), and also make our codebase more extensible should we or anyone else decide in the future to add / remove user types. It would also make my implementation of #6 (CSV import) much simpler for assignment of user types..
[An initial thought on this: Map NIL, (blank), 'patron', and 'normal' to all mean the same thing, so for CSV import admins have some flexibility / freedom from jargon.]
Also,
adminmode, checkoutpersonmode, normalusermode, and bannedmode
should either be similarly consolidated or else completely moved to the session (ideal).
The text was updated successfully, but these errors were encountered:
I'm redoing the rspec tests as I make these changes, but it's also going to break part of the seed script. Sorry @mnquintana, I'll leave that fix to you!
Right now in the Users database table we have the following columns:
IMO we should consolidate is_banned, is_admin, is_checkout_person into:
This way we could avoid the ludicrous (although theoretically possible) situations of Banned-Admins and Admin-Checkoutpersons (there might be a validation against these??), and also make our codebase more extensible should we or anyone else decide in the future to add / remove user types. It would also make my implementation of #6 (CSV import) much simpler for assignment of user types..
[An initial thought on this: Map NIL, (blank), 'patron', and 'normal' to all mean the same thing, so for CSV import admins have some flexibility / freedom from jargon.]
Also,
should either be similarly consolidated or else completely moved to the session (ideal).
The text was updated successfully, but these errors were encountered: