This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
[1378] Improve user profile history tables [v5.5] #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyk
force-pushed
the
1378_unsortable_table_55
branch
from
863648e
to
4082583
Compare
|
This is ready for review now that it's been squashed; I'm waiting to issue the PR for |
Resolves #1378 - re-add datatables to user profiles - remove datatables gem and replace with vendor assets - implement default sorting for different categories - make general improvements to controller / partial
orenyk
force-pushed
the
1378_unsortable_table_55
branch
from
4082583
to
eb1a7f5
Compare
|
Just fixed an indentation mismatch - I'd really like this reviewed again although for the sake of getting this user-tested I'm going to just merge this in now and we'll have a proper review done when it's cherry-picked onto |
orenyk
added a commit
that referenced
this pull request
Jan 6, 2016
[1378] Improve user profile history tables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1378 for v5.5.