Use the newer recommended S3 ListObjectsV2 API #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuli007
requested review from
vulpine,
jvperrin,
ahaswell,
bobtfish and
janpokrzywinski
bobtfish
approved these changes
Mar 22, 2022
vulpine
approved these changes
Mar 22, 2022
giuli007
force-pushed
the
faster_s3_listbojectsv2
branch
from
f3590eb
to
4142c9b
Compare
giuli007
force-pushed
the
faster_s3_listbojectsv2
branch
from
4142c9b
to
4b4408c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of giuli007#1 (based off a recent master and not including the changes in aptly-dev#1002 so they can be merged separately) to be merged into the Yelp fork of aptly along with other changes so we can streamline changes to aptly from different contributors and build them internally.
Copied the relevant description for visibility
Fixes
This change is to addresses a situation we have encountered running in AWS EKS where each single (1000-paginated) request using the older
ListObjectsAPI vias3.ListObjectsPagestakes seconds to receive a response, resulting in tens of minutes long publishing times when the bucket contains >100k packages (which is the cases for repos mirrored from ubuntu repos and republished in-house).This doesn't look like normal throttling as no explicit throttled responses are seen when enabling
debugin the https://www.aptly.info/doc/configuration/. The reasons why the old API is so slow only when running in EKS are still unknown.Description of the Change
Uses the more modern recommended
ListObjectsV2to list objects on the S3 bucket when publishing to it.https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html
This is faster, especially when running in EKS.