Upgrading k8s lib #3965
Upgrading k8s lib #3965
Conversation
paasta_tools/kubernetes_tools.py
Outdated
| self.apiextensions_v1_beta1 = kube_client.ApiextensionsV1beta1Api( | ||
| self.api_client | ||
| ) | ||
| # self.apiextensions_v1_beta1 = kube_client.ApiextensionsV1beta1Api( |
There was a problem hiding this comment.
this was needed to go to k8s 1.22, should we remove it completely? I just wanted to keep it in case we face the same change of API in the future
There was a problem hiding this comment.
if we need this code again we can grab it from git history :)
paasta_tools/kubernetes_tools.py
Outdated
| self.apiextensions_v1_beta1 = kube_client.ApiextensionsV1beta1Api( | ||
| self.api_client | ||
| ) | ||
| # self.apiextensions_v1_beta1 = kube_client.ApiextensionsV1beta1Api( |
There was a problem hiding this comment.
if we need this code again we can grab it from git history :)
| desired_crds: Collection[Union[V1CustomResourceDefinition]], | ||
| existing_crds: Union[V1CustomResourceDefinitionList], |
There was a problem hiding this comment.
| desired_crds: Collection[Union[V1CustomResourceDefinition]], | |
| existing_crds: Union[V1CustomResourceDefinitionList], | |
| desired_crds: Collection[V1CustomResourceDefinition], | |
| existing_crds: V1CustomResourceDefinitionList, |
we don't need a union anymore since we're using a single type now :)
| @@ -175,7 +174,7 @@ def setup_all_custom_resources( | |||
| ).items | |||
| except ApiException: | |||
| log.debug( | |||
| "Listing CRDs with apiextensions/v1 not supported on this cluster, falling back to v1beta1" | |||
| "Listing CRDs with apiextensions/v1 not supported on this cluster" | |||
There was a problem hiding this comment.
imo: i think we'd want to revert the changes to this file where we added the for loop rather than make this a for loop over a single version
There was a problem hiding this comment.
(it would make the code more straightforward and while we may need to handle new apiextension versions in the future, imo it'd be better to only temporarily have this sort of multi-version code)
We need to update the kubernetes library to newer versions.
Containerd gives problems when looking for container image names with the kubernetes client in the current version.
PAASTA-18345
ticket describing the issue COMPINFRA-4411 and doc