Try to produce consistent monorepo tgz hashes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in them, which totally broke this script
|
By the way I won't be nesting more async levels. Will have to port the stuff to async+await. |
|
Looks like this didn't solve the problem at build. I'll need to think harder :) |
This reverts commit dc8ad09.
|
Includes #35 Built |
|
The issue seems to have been some platform dependence in nodejs's zlib. The best reference I could find was nodejs/node#12244 but I'm not sure it's the same problem. Using pako instead on all platforms. |
|
@atamon Seems to work across dev+build. Ok to merge? |
|
Go ahead! I think I got the gist of this PR at least :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hashes should be for a minimal tgz, with only a package.json containing
dependencies. I think file timestamps was the issue, but we need to validate this for actual builds not only https://github.com/solsson/npm-monorepo-example