-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zcash_script’s new Script
trait
#8751
base: main
Are you sure you want to change the base?
Conversation
This depends on ZcashFoundation/zcash_script#171. |
e47cdfc
to
9e5014b
Compare
38617ec
to
f80b392
Compare
Thank you for your PR! We're focusing on changes for NU6 testnet activation at the moment so we won't be able to prioritise this review for another week or two. |
d5cbe2f
to
9d931b0
Compare
This is a precursor to testing the Rust implementation of Zcash Script.
9d931b0
to
8449878
Compare
Re: the unchecked checkboxes
|
We usually check boxes if they don't apply to the PR.
Added a priority label. Added a |
What's next here? I see ZcashFoundation/zcash_script#171 has merged |
We should double check this PR works with zcash_script |
Motivation
This is a precursor to testing the Rust implementation of Zcash Script.
Blocked-On: ZcashFoundation/zcash_script#171 and publishing a new version of
zcash_script
with those changes.Solution
This uses a trait that wraps the C++ Zcash Script implementation. As we progress toward cutting over to a Rust implementation, this trait will additionally have impls for the Rust version and a variant that runs both C++ & Rust, comparing the results.
Additionally, this eliminates a few cases from
zebra_script::Error
that can never be produced.Tests
The tests are the same as the previous zebra_script tests – there should be no change in behavior.
Follow-up Work
This is blocked on a release of zcash_script containing ZcashFoundation/zcash_script#171.
PR Author's Checklist
PR Reviewer's Checklist