Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Upgrade ECC dependencies #8810

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We need to upgrade the ECC dependencies for NU6.

Close #8749
Close #8799

Solution

We can upgrade the root Cargo.toml which makes this a lot easier (thank you @tomekpiotrowski !).

However, we need to remain in older versions for some of the ECC crates in the zebra-scan crate for now.

Tests

CI should take care of this.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added A-dependencies Area: Dependency file updates NU-6 Network Upgrade: NU6 specific tasks P-High 🔥 labels Aug 27, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner August 27, 2024 19:16
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team August 27, 2024 19:16
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Aug 27, 2024
@arya2
Copy link
Contributor

arya2 commented Aug 27, 2024

Thank you!

Looks like we need to update the deny.toml here as well.

@arya2 arya2 changed the title build(deps): Upgrade ECC depenencies build(deps): Upgrade ECC dependencies Aug 27, 2024
@arya2 arya2 force-pushed the upgrade-ecc-deps-nu6-testnet branch from 67ecdc8 to 80b60d1 Compare August 27, 2024 21:33
mergify bot added a commit that referenced this pull request Aug 27, 2024
@mergify mergify bot merged commit 6922e71 into main Aug 27, 2024
132 of 133 checks passed
@mergify mergify bot deleted the upgrade-ecc-deps-nu6-testnet branch August 27, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG NU-6 Network Upgrade: NU6 specific tasks P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade librustzcash dependencies to a NU6 release version.
2 participants