Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that control characters were not escaped properly when written to file. It seems to me that as long as strings are in memory (C strings or std::string) the control codes should not be escaped, they should only be escaped when written to a stream and unescaped when parsed from a stream. So that's where I put the calls.
This may or may not be the best fix for this issue, but it seems to work.
Also, the test I added is a bit wonky and you might want to change it.
My editor whitespace settings seem to be incompatible with yours or github's, so I reverted and recommitted with less changes to whitespace (by making targeted edits) but there's still seems to be alignment issues. Anyway, that's why there are 3 commits.