Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Display Reservation modal #23

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

BryteLitty
Copy link
Collaborator

In this project, I did the following:

  • created a single reservation button on the home page since there's no item on the page at the moment
  • added a modal section to the HTML file
  • created a JavaScript function to listen for click event when the reservation button is clicked, this pops up the modal when the button gets clicked
  • added a form, image and other info to the modal page
  • added event listener to the close button on the modal. This closes the modal when it gets clicked

Copy link
Owner

@ZuhRa-HashiMi ZuhRa-HashiMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

Hi @BryteLitty 💯 💯 💯
Good job so far! 👏🏼 👏🏼 👏🏼
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️

src/index.html Show resolved Hide resolved
src/index.html Show resolved Hide resolved
src/index.html Show resolved Hide resolved
@BryteLitty
Copy link
Collaborator Author

BryteLitty commented Dec 1, 2022

Hi @ZuhRa-HashiMi,

Thank you for your feedback. In regard to the changes you suggest, the API feature is supposed to be implemented in the second PR not. This PR is only to pop up the modal when the user clicks on the reservation button.
Thanks for pointing that out, I sure will implement that in my next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants