Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display popup comments #33

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Display popup comments #33

merged 5 commits into from
Dec 2, 2022

Conversation

Ofarouq310
Copy link
Collaborator

Summary of branch implementations:

- Upon the user click on the (Comments) button on the homepage layout:

  • Create a comments popup only with the top section (displaying details of the selected item).
  • "Form" section is added in addition to the "Comments" section which will be displayed dynamically in the next two tasks.

Please, refer to task details, if needed: #14

Copy link
Owner

@ZuhRa-HashiMi ZuhRa-HashiMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project Approved 🏆 🎉
Hi @Ofarouq310

Your project is complete! You have done it exceptionally well. it's time to merge it 💯
Congratulations! 🎉

To Highlight 👍
✔️ No linter error.
✔️ Descriptive readme file.
✔️ Well-implemented suggested change.

Optional suggestions 🔽
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification. You can also connect with me on slack

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Ofarouq310 Ofarouq310 merged commit 0eb2a19 into dev Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants